Repository navigation
test: only trusted code clears an interrupt that it requested (Qore #5659) - #67
Merged
Merged
Conversation
…5659) Since Qore b920ac93a2 code whose functional domains are restricted may add a restriction to a SandboxManager it did not create, as requestInterrupt() does, but not lift one: its clearInterrupt() raises SANDBOX-ACCESS-ERROR. The sandbox interrupt test cleared the interrupt from the restricted Program, so it failed in every job of module CI on Qore f2ca5f454a. The restricted Program still requests the interrupt, and its clearInterrupt() is now checked to be refused; the trusted host clears the interrupt, after which a call into Python succeeds again. Claude-Session: https://claude.ai/code/session_01LYRBCx7VH62zrrgecKSHre
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since Qore b920ac93a2 (#5659), code whose functional domains are restricted may add a restriction to a
SandboxManagerit did not create, asrequestInterrupt()does, but not lift one: itsclearInterrupt()raisesSANDBOX-ACCESS-ERROR. The sandbox interrupt test cleared the interrupt from the restricted Program, so it failed in all six jobs of module CI on Qore f2ca5f454a (mirror/module-python pipeline 64094).PROGRAM-INTERRUPTED, Python GIL)clearInterrupt()is now checked to be refused withSANDBOX-ACCESS-ERRORTest plan
test/python.qtest"sandbox interrupt test": fails on the old test withSANDBOX-ACCESS-ERROR, passes with this change (10 assertions), on Qore f2ca5f454atest/python.qtest: 86/86🤖 Generated with Claude Code
https://claude.ai/code/session_01LYRBCx7VH62zrrgecKSHre